Skip to content

drivers: firmware: Clock control TISCI driver support #90216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: firmware: Clock control TISCI driver support #90216

wants to merge 1 commit into from
+175 −0

Conversation

Kronosblaster
Copy link
Contributor

@Kronosblaster Kronosblaster commented May 20, 2025 •
edited
Loading

Support added for clock control using TISCI added for devices using the binding ti,k2g-sci-clk. This PR waits on #90053

Testing

Refer: ClockControllerTest

Output:

DMSC Firmware Version 11.0.7--v11.00.07 (Fancy Rat)                                                 
DMSC Firmware revision 0xb                                                                          
DMSC ABI revision 4.0                                                                               
                                                                                                    
INFO: Bootloader_runCpu:205: CPU r5f1-0  is initialized to 800000000 Hz !!!                         
INFO: Bootloader_runCpu:205: CPU r5f1-1 is initialized to 800000000 Hz !!!                          
INFO: Bootloader_runCpu:205: CPU m4f0-0 is initialized to 400000000 Hz !!!                          
INFO: Bootloader_runCpu:205: CPU a530-0 is initialized to 800000000 Hz !!!                          
INFO: Bootloader_runCpu:205: CPU a530-1 is initialized to 800000000 Hz !!!                          
INFO: Bootloader_loadSelfCpu:257: CPU r5f0-0 is initialized to 800000000 Hz !!!                     
INFO: Bootloader_loadSelfCpu:257: CPU r5f0-1 is initialized to 800000000 Hz !!!                     
INFO: Bootloader_runSelfCpu:267: All done, reseting self ...                                        
                                                                                                    
*** Booting Zephyr OS build v4.1.0-5562-g50269a5c5de1 ***                                           
Current clock rate: 48000000                                                                        
Clock rate set to 96000000                                                                          
Clock rate set to 48000000                                                                          
Current clock rate after set: 48000000                                                              
All clock controller tests passed!

@Kronosblaster Kronosblaster force-pushed the clockControl branch 6 times, most recently from 7cf310e to 2dc18ee Compare May 27, 2025 11:17
@Kronosblaster Kronosblaster force-pushed the clockControl branch 2 times, most recently from 8b10b9f to 9ee64d7 Compare June 9, 2025 08:08
@Kronosblaster Kronosblaster force-pushed the clockControl branch 7 times, most recently from 9a47dbf to 20b38b7 Compare June 10, 2025 13:18
@Kronosblaster Kronosblaster marked this pull request as ready for review June 10, 2025 13:19
@github-actions github-actions bot added platform: TI SimpleLink Texas Instruments SimpleLink MCU area: Clock Control labels Jun 10, 2025
@Kronosblaster Kronosblaster force-pushed the clockControl branch 4 times, most recently from 6bd0da6 to 7f1f9bf Compare June 11, 2025 10:38
@vaishnavachath vaishnavachath added the DNM This PR should not be merged (Do Not Merge) label Jun 17, 2025
@Kronosblaster Kronosblaster force-pushed the clockControl branch 3 times, most recently from 2154640 to 20a6a86 Compare June 23, 2025 05:47
@Kronosblaster Kronosblaster requested a review from glneo August 28, 2025 05:00
@Kronosblaster Kronosblaster force-pushed the clockControl branch 2 times, most recently from 7adcf73 to 8c035e7 Compare September 2, 2025 05:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@glneo
Copy link
Contributor

glneo commented Sep 2, 2025

Looks good to me now, but I'm not sure how useful this is by itself, it seems to just be a dependency patch for #91914 that got its own PR. I guess that is fine to do pre-work in this way when it affects a different subsystem, but I think next time patches like this can just go into the PR that uses them.

glneo
glneo previously approved these changes Sep 2, 2025
View reviewed changes
vaishnavachath
vaishnavachath previously approved these changes Sep 3, 2025
View reviewed changes
@Kronosblaster
Copy link
Contributor Author

Looks good to me now, but I'm not sure how useful this is by itself, it seems to just be a dependency patch for #91914 that got its own PR. I guess that is fine to do pre-work in this way when it affects a different subsystem, but I think next time patches like this can just go into the PR that uses them.

This is useful for all forms of clock regulation via TISCI. The init is one of the uses. Drivers can now regulate clocks which wasn't possible before.

@natto1784 natto1784 mentioned this pull request Sep 18, 2025
Open
@natto1784
Copy link
Contributor

Hey @nordic-krch, apologies for the ping, if there is not anything blocking this, can this be merged?

@natto1784
Copy link
Contributor

natto1784 commented Oct 8, 2025 •
edited
Loading

also I feel like the addition of the controller in DT can be moved from #91914 to here

nordic-krch
nordic-krch previously approved these changes Oct 9, 2025
View reviewed changes
@Kronosblaster
drivers: firmware: Clock control TISCI driver support
86fd461 
Support added for clock control using TISCI for devices using the binding
ti,k2g-sci-clk. This driver relies on the TISCI layer to make calls to the
DMSC core to set and get the clock rate and retrieve clock status.

Signed-off-by: Dave Joseph <[email protected]>
@Kronosblaster
Copy link
Contributor Author

Kronosblaster commented Oct 13, 2025 •
edited
Loading

@vanti Can this is reviewed?
This was previously approved by @glneo, @vaishnavachath, @nordic-krch. PR was rebased to facilitate merge.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JarmouniA
JarmouniA reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enabled on at least one board in-tree and be tested with an existing or a new testsuite.

@Kronosblaster
Copy link
Contributor Author

Should be enabled on at least one board in-tree and be tested with an existing or a new testsuite.

This driver currently only wraps the merged #90053 (TISCI driver). Its use-case #91914 depends on multiple subsystems and is organized into another PR which will contain the required in-tree changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JarmouniA JarmouniA JarmouniA left review comments

@glneo glneo glneo approved these changes

@vaishnavachath vaishnavachath vaishnavachath approved these changes

@vanti vanti Awaiting requested review from vanti

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

+1 more reviewer

@natto1784 natto1784 natto1784 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nordic-krch nordic-krch

Labels

area: Boards/SoCs area: Clock Control area: Devicetree Bindings platform: TI SimpleLink Texas Instruments SimpleLink MCU

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Kronosblaster @glneo @natto1784 @nordic-krch @vaishnavachath @JarmouniA @zephyrbot